Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update module github.com/golang/glog to v1.2.4 #20293

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix(deps): update module github.com/golang/glog to v1.2.4 #20293

merged 1 commit into from
Jan 13, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 13, 2025 •
edited by sourcery-ai bot
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/golang/glog v1.2.3 -> v1.2.4 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

golang/glog (github.com/golang/glog)

v1.2.4

Compare Source

What's Changed

Full Changelog: golang/glog@v1.2.3...v1.2.4

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Summary by Sourcery

Build:

  • Update glog dependency to v1.2.4.

@renovate
fix(deps): update module github.com/golang/glog to v1.2.4
3aad2d9 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot requested a review from batazor as a code owner January 13, 2025 11:05
@renovate renovate bot enabled auto-merge January 13, 2025 11:05
@renovate renovate bot added this pull request to the merge queue Jan 13, 2025
@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jan 13, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This PR updates the github.com/golang/glog module from v1.2.3 to v1.2.4 in two files: boundaries/platform/csi/go.mod and go.mod. The update includes changes to how log files are handled, specifically preventing attempts to create or rotate a given syncBuffer twice in the same second and introducing a createInDir function that fails if the log file already exists.

Sequence diagram for updated log file handling in glog v1.2.4

sequenceDiagram
    participant Logger as Glog Logger
    participant FileSystem as File System
    participant SyncBuffer as SyncBuffer

    Logger->>FileSystem: Check if log file exists
    alt File exists
        FileSystem-->>Logger: File exists
        Logger->>Logger: Fail operation
    else File doesn't exist
        FileSystem-->>Logger: File doesn't exist
        Logger->>FileSystem: Create log file
        Logger->>SyncBuffer: Initialize buffer
        Note over Logger, SyncBuffer: Prevents double creation<br/>in same second
    end
Loading

Class diagram for glog v1.2.4 changes

classDiagram
    class logging {
        +createInDir(name string) error
        +syncBuffer struct
    }

    class syncBuffer {
        -file *os.File
        +rotateFile() error
    }

    logging --> syncBuffer
    note for syncBuffer "Now prevents duplicate
creation/rotation in same second"
Loading

File-Level Changes

Change Details Files
Updated the github.com/golang/glog module from v1.2.3 to v1.2.4
  • Changed the required version in go.mod files
 boundaries/platform/csi/go.mod
go.mod
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, renovate[bot]!). We assume it knows what it's doing!

Merged via the queue into main with commit f96fa99 Jan 13, 2025
16 of 26 checks passed
@renovate renovate bot deleted the renovate/github.com-golang-glog-1.x branch January 13, 2025 11:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@batazor batazor Awaiting requested review from batazor batazor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants